PRO-16890 : Enforce required flags for provar:metadatacache #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command started executing even when required flags were not given. Changed that to give error in typescript itself. Also made changes to make sure that the flags work correctly in tandem.
riteshnahar
suggested changes
Aug 26, 2020
src/commands/provar/metadatacache.ts
Outdated
| return {}; | ||
| } | ||
|
|
||
| if ( |
There was a problem hiding this comment.
Change it to:
if (!["Reload", "Refresh", "Reuse"].includes(metadataLevel))
src/commands/provar/metadatacache.ts
Outdated
| this.ux.error( | ||
| '[ERROR] No valid user org found to download metadata. Terminating command.' | ||
| ); | ||
| return {}; | ||
| } | ||
|
|
||
| const userInfoString = provarDxUtils.prepareRawProperties( | ||
| const userInfoString = connections && userInfo == null ? "NA" : provarDxUtils.prepareRawProperties( |
Corrected conditional checks to use "===" & '!==' for comparison and renamed variables with self explanatory names
riteshnahar
approved these changes
Aug 28, 2020
simoncarter-provar
suggested changes
Aug 28, 2020
src/commands/provar/metadatacache.ts
Outdated
| return {}; | ||
| } | ||
|
|
||
| (!["Reload", "Refresh", "Reuse"].includes(metadataLevel)) { |
There was a problem hiding this comment.
Should this be an if statement?
if (!["Reload", "Refresh", "Reuse"].includes(metadataLevel)) {
simoncarter-provar
approved these changes
Aug 28, 2020
riteshnahar
added a commit
that referenced
this pull request
Sep 11, 2020
* PRO-16810: ProvarDX Incorrect Help messages (#23) - Updated help messages for runtests, validate commands displayed on running `sfdx provar --help` - Updated company name in LICENSE.md * PRO-16923: ProvarDX runtests fails to handle special characters in Scratch Org Passwords properly (#25) * PRO-16923: ProvarDX runtests fails to handle special characters in Scratch Org Passwords properly * PRO-16923: Special characters were causing issues on different OS so encoded the password * PRO-16897: ProvarDX: Runtests secrets flag override incorrectly documented * PRO-16897: ProvarDX: Runtests secrets flag override incorrectly documented * PRO-16890 : Enforce required flags for provar:metadatacache (#26) * PRO-16890 : Enforce required flags for provar:metadatacache The command started executing even when required flags were not given. Changed that to give error in typescript itself. Also made changes to make sure that the flags work correctly in tandem. * PRO-16890 : Implement review comments and add change log * PRO-16890 : Implement review comments Corrected conditional checks to use "===" & '!==' for comparison and renamed variables with self explanatory names * PRO-16890 : Implement review comments Co-authored-by: mayank.nehru <mayank.nehru@HP-Mayanknehru> * PRO-17213: ProvarDX 0.3.0 release (#27) Bumped version to 0.3.0 Co-authored-by: Mayank Nehru <mayank.nehru@provartesting.com> Co-authored-by: mayank.nehru <mayank.nehru@HP-Mayanknehru> Co-authored-by: ProvarTesting <6640365+ProvarTesting@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command started executing even when required flags were not given. Changed that to give error in typescript itself. Also made changes to make sure that the flags work correctly in tandem.